-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Use this.getLicense
to instead of this._license
when calculating shouldPreventAction map
#31008
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5.0 #31008 +/- ##
================================================
Coverage ? 51.27%
================================================
Files ? 813
Lines ? 15242
Branches ? 2819
================================================
Hits ? 7815
Misses ? 6991
Partials ? 436
Flags with carried forward coverage won't be shown. Click here to find out more. |
aca60c6
to
9a06ef2
Compare
@@ -145,6 +145,7 @@ export class LicenseManager extends Emitter<LicenseEvents> { | |||
|
|||
private invalidateLicense(): void { | |||
this._valid = false; | |||
this.states.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggazzo shouldn't the call on "clearLicenseData" do the same?
9a06ef2
to
1eceadb
Compare
…et.Chat into regression/this._license
NBJ-540
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments