Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Use this.getLicense to instead of this._license when calculating shouldPreventAction map #31008

Merged
merged 8 commits into from
Nov 24, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Nov 17, 2023

NBJ-540

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Nov 17, 2023

⚠️ No Changeset found

Latest commit: 0538e67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added this to the 6.5 milestone Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5.0@72b6efe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6799d13 differs from pull request most recent head 0538e67. Consider uploading reports for the commit 0538e67 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-6.5.0   #31008   +/-   ##
================================================
  Coverage                 ?   51.27%           
================================================
  Files                    ?      813           
  Lines                    ?    15242           
  Branches                 ?     2819           
================================================
  Hits                     ?     7815           
  Misses                   ?     6991           
  Partials                 ?      436           
Flag Coverage Δ
e2e 48.21% <0.00%> (?)
unit 66.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman requested a review from ggazzo November 17, 2023 20:06
@ggazzo ggazzo force-pushed the regression/this._license branch from aca60c6 to 9a06ef2 Compare November 17, 2023 23:22
@@ -145,6 +145,7 @@ export class LicenseManager extends Emitter<LicenseEvents> {

private invalidateLicense(): void {
this._valid = false;
this.states.clear();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggazzo shouldn't the call on "clearLicenseData" do the same?

@KevLehman KevLehman force-pushed the regression/this._license branch from 9a06ef2 to 1eceadb Compare November 20, 2023 15:04
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 20, 2023
@ggazzo ggazzo marked this pull request as ready for review November 24, 2023 01:23
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 24, 2023
@ggazzo ggazzo merged commit 6e489fc into release-6.5.0 Nov 24, 2023
6 of 7 checks passed
@ggazzo ggazzo deleted the regression/this._license branch November 24, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants