-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Omnichannel queue processing #34192
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34192 +/- ##
============================================
+ Coverage 59.13% 74.98% +15.85%
============================================
Files 2819 516 -2303
Lines 67957 22741 -45216
Branches 15138 5517 -9621
============================================
- Hits 40188 17053 -23135
+ Misses 24935 5024 -19911
+ Partials 2834 664 -2170
Flags with carried forward coverage won't be shown. Click here to find out more. |
c1b3b9a
Proposed changes (including videos or screenshots)
Refactor includes 3 aspects:
waiting queue
is enabled.unlockAndRequeue
and replcaes it with justunlock
. This change shouldn't be noticeable. The original idea of therequeueing
was to iterate over the inquiries when 1 wasn't being able to be taken. Idea was to avoid blocking the queue by rotating them instead of fetching the same until it gets routed, however this never worked cause we never modified the global sorting for the inquiries and it kept using thets
as the sorting, which returned always the oldest and ignored the requeing. So we're removing those extra steps as well.Other smol changes:
maxChats
functions should always be numbers.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-896
Steps to test or reproduce
Further comments