Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rocket.cat complains about mongo version #34892

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jan 6, 2025

Proposed changes (including videos or screenshots)

We were not injecting the mongo version inside the string

Before

Captura de Tela 2025-01-10 às 09 32 33

After

Captura de Tela 2025-01-10 às 09 31 24

Issue(s)

#34862
CORE-921

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 6, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 670e732

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34892/
on branch gh-pages at 2025-01-10 11:53 UTC

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.14%. Comparing base (4aa95b6) to head (670e732).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34892    +/-   ##
=========================================
  Coverage    59.13%   59.14%            
=========================================
  Files         2819     2819            
  Lines        67957    67406   -551     
  Branches     15138    15028   -110     
=========================================
- Hits         40188    39864   -324     
+ Misses       24935    24729   -206     
+ Partials      2834     2813    -21     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb changed the title fix: Rocket.cat complains about %s mongo version fix: Rocket.cat complains about '%s' mongo version Jan 6, 2025
@Gustrb Gustrb changed the title fix: Rocket.cat complains about '%s' mongo version fix: Rocket.cat complains about mongo version Jan 6, 2025
@Gustrb Gustrb marked this pull request as ready for review January 6, 2025 17:41
@Gustrb Gustrb requested a review from a team as a code owner January 6, 2025 17:41
@scuciatto scuciatto added this to the 7.3.0 milestone Jan 9, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Jan 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2025
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gustrb since you assured the QA here, can you attach a screenshot with the before/after into the PR description please?

@Gustrb
Copy link
Contributor Author

Gustrb commented Jan 10, 2025

oh yea sure, just a sec

@Gustrb Gustrb added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jan 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2025
@kodiakhq kodiakhq bot merged commit 9af2774 into develop Jan 10, 2025
55 checks passed
@kodiakhq kodiakhq bot deleted the fix/rocket-cat-sending-%s branch January 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants