-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rocket.cat complains about mongo version #34892
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 670e732 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34892 +/- ##
=========================================
Coverage 59.13% 59.14%
=========================================
Files 2819 2819
Lines 67957 67406 -551
Branches 15138 15028 -110
=========================================
- Hits 40188 39864 -324
+ Misses 24935 24729 -206
+ Partials 2834 2813 -21
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gustrb since you assured the QA here, can you attach a screenshot with the before/after into the PR description please?
oh yea sure, just a sec |
Proposed changes (including videos or screenshots)
We were not injecting the mongo version inside the string
Before
After
Issue(s)
#34862
CORE-921
Steps to test or reproduce
Further comments