Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Room not loading history #34900

Merged
merged 6 commits into from
Jan 15, 2025
Merged

fix: Room not loading history #34900

merged 6 commits into from
Jan 15, 2025

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 7, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Room was not loading room history when scrolled to the top of the room.

Steps to test or reproduce

  • Go to room A
  • Go to room B
  • Go back to room A and scroll all the way up
  • It doesn't load history for room A (instead loads for room B)

Further comments

SUP-683

Copy link
Contributor

dionisio-bot bot commented Jan 7, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 901ce98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review January 7, 2025 14:56
@yash-rajpal yash-rajpal requested a review from a team as a code owner January 7, 2025 14:56
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34900/

Built to branch gh-pages at 2025-01-15 14:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (2f5e287) to head (901ce98).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34900    +/-   ##
=========================================
  Coverage    59.12%   59.13%            
=========================================
  Files         2819     2819            
  Lines        67901    67354   -547     
  Branches     15124    15011   -113     
=========================================
- Hits         40149    39832   -317     
+ Misses       24919    24710   -209     
+ Partials      2833     2812    -21     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Jan 7, 2025
@yash-rajpal yash-rajpal added this to the 7.3.0 milestone Jan 7, 2025
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jan 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 15, 2025
@kodiakhq kodiakhq bot merged commit e6eff85 into develop Jan 15, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/room-loadhistory branch January 15, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants