Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imported fixes 25-01-07 #34904

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: imported fixes 25-01-07 #34904

merged 2 commits into from
Jan 8, 2025

Conversation

julio-rocketchat
Copy link
Member

@julio-rocketchat julio-rocketchat commented Jan 7, 2025

Proposed changes (including videos or screenshots)

At this point, I see no need to backport these changes since they are minor improvements.

Issue(s)

VLN-85
VLN-86
VLN-87

Steps to test or reproduce

N/A

Further comments

N/A

Copy link
Contributor

dionisio-bot bot commented Jan 7, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: c68a8d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34904/
on branch gh-pages at 2025-01-08 10:56 UTC

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (1cc2bc7) to head (d7a77b1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34904      +/-   ##
===========================================
- Coverage    59.13%   59.13%   -0.01%     
===========================================
  Files         2821     2819       -2     
  Lines        67965    67957       -8     
  Branches     15142    15138       -4     
===========================================
- Hits         40193    40188       -5     
+ Misses       24938    24935       -3     
  Partials      2834     2834              
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-rocketchat julio-rocketchat added this to the 7.3.0 milestone Jan 7, 2025
@julio-rocketchat julio-rocketchat marked this pull request as ready for review January 8, 2025 03:08
@julio-rocketchat julio-rocketchat requested review from a team as code owners January 8, 2025 03:08
---------

docs: add changeset

Fix bug in createToken.ts

Fix lint

Fix lint error
@julio-rocketchat julio-rocketchat force-pushed the imported-fixes-2025-01-07 branch from b32fcc3 to c68a8d6 Compare January 8, 2025 12:33
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jan 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@kodiakhq kodiakhq bot merged commit c7be829 into develop Jan 8, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the imported-fixes-2025-01-07 branch January 8, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants