-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace Menu
in favor of GenericMenu
in RoomMenu
#34927
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
65e2655
to
ab5b1a4
Compare
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34927 +/- ##
===========================================
+ Coverage 59.13% 59.18% +0.05%
===========================================
Files 2819 2819
Lines 67871 67734 -137
Branches 15117 15083 -34
===========================================
- Hits 40133 40087 -46
+ Misses 24907 24821 -86
+ Partials 2831 2826 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
ARCH-1405