Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retention policy settings migration not running #34935

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jan 10, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-924

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 10, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 5d0f483

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34935/

Built to branch gh-pages at 2025-01-14 17:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (1f54b73) to head (5d0f483).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34935   +/-   ##
========================================
  Coverage    59.12%   59.12%           
========================================
  Files         2819     2819           
  Lines        67938    67938           
  Branches     15134    15134           
========================================
  Hits         40171    40171           
  Misses       24934    24934           
  Partials      2833     2833           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added this to the 7.3.0 milestone Jan 10, 2025
@gabriellsh gabriellsh marked this pull request as ready for review January 10, 2025 20:59
@gabriellsh gabriellsh requested a review from a team as a code owner January 10, 2025 20:59
KevLehman
KevLehman previously approved these changes Jan 10, 2025
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring back the softmigration and wait for the next major release to remove run the migration properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants