Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve permissions search #34939

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jan 13, 2025

CONN-458

Proposed changes (including videos or screenshots)

Searching permissions was only working with the words of the permission's ID.
Kapture 2025-01-09 at 15 35 35

Now the search results also matches with the translation on the UI.
Kapture 2025-01-13 at 11 26 39

Issue(s)

closes #34843
closes #28227
closes #22295
closes #27844
closes #30983

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 13, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 50f3ae1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (0517a05) to head (50f3ae1).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34939      +/-   ##
===========================================
- Coverage    59.12%   59.12%   -0.01%     
===========================================
  Files         2819     2819              
  Lines        67939    67935       -4     
  Branches     15134    15134              
===========================================
- Hits         40172    40168       -4     
  Misses       24934    24934              
  Partials      2833     2833              
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34939/

Built to branch gh-pages at 2025-01-15 18:21 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@juliajforesti juliajforesti force-pushed the feat/search-permissions branch 3 times, most recently from 6207d4e to de4d4cf Compare January 15, 2025 18:14
@juliajforesti juliajforesti force-pushed the feat/search-permissions branch from de4d4cf to f275d82 Compare January 15, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant