New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug on empty response #6

Open

AlexDochioiu wants to merge 3 commits into RootSoft:master from vespr-wallet:bug/err_on_empty_response

AlexDochioiu commented Mar 11, 2024

Updated dependencies (and raised min dart/flutter version)
Made onData/onError non-nullable for reader since they are always passed
Stopped translating responses with only code as being failure (there are valid success empty responses in many cases)

Each ledger app's transformer / interaction should handle error response code (the success code seems to be different for most ledger apps)

AlexDochioiu added 3 commits

March 11, 2024 17:16


          * Updated deps

4e0b8e6

* Updated reader to accept empty response ; app transformer should handle success/error codes instead


          Remove unused error data size

93c9349


          Added back reset which was removed by mistake

f9dfd3d

AlexDochioiu force-pushed the bug/err_on_empty_response branch from 97d3bdc to f9dfd3d Compare

March 11, 2024 15:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet