Fix double initialisation when two appmetrics instances are started (singleton bug) #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was discovered with the implementation of the appmetrics global singleton. Essentially a lot of initialization code was being run twice including attaching the probes and the socket.io probe doesn't have a global check for whether it is already attached. This PR only runs the initialization code once.
See RuntimeTools/appmetrics-dash#124