-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing
to rustc_codegen_spirv
#193
Conversation
Open questions:
|
tokio-rs/tracing#3183 for |
I'm not sure I agree with the lint...I am mirroring what |
tokio-rs/tracing#3184 for regex stuff. |
6621970
to
892f3d8
Compare
I am not going to document this until a future PR where there is actually logging in place. |
tracing
to rustc_codegen_spirv
@Firestar99 any thoughts on the open questions in #193 (comment) ? |
To most of these: I don't really know, as I haven't used the tracing feature, nor done more than 2 weeks of hacking in the actual compiler. Most of my contributions have been intrinsics, which don't need deep end compiler changes, or just rebasing stuff.
|
Ok, I am going to land these then and we can change later. |
Fixes #192