Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sk constructors #201

Merged
merged 5 commits into from
Mar 9, 2024
Merged

Sk constructors #201

merged 5 commits into from
Mar 9, 2024

Conversation

jviki
Copy link
Contributor

@jviki jviki commented Mar 6, 2024

Introducing draft of SkEcdsaSha2NistP256::new() and SkEd25519::new(). It's just public keys, code for private keys would eventually follow.

Based on #200, would this be a way to go?

tarcieri
tarcieri reviewed Mar 6, 2024
View reviewed changes
ssh-key/src/public/sk.rs Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Mar 6, 2024
View reviewed changes
ssh-key/src/public/sk.rs Outdated Show resolved Hide resolved
@jviki jviki force-pushed the sk-constructors branch from b278010 to 627a87a Compare March 6, 2024 14:50
tarcieri
tarcieri reviewed Mar 6, 2024
View reviewed changes
ssh-key/src/public/sk.rs Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Mar 6, 2024
View reviewed changes
ssh-key/src/public/sk.rs Outdated Show resolved Hide resolved
@jviki jviki force-pushed the sk-constructors branch 3 times, most recently from 9d070e7 to 8767cd4 Compare March 6, 2024 20:55
@jviki jviki force-pushed the sk-constructors branch 2 times, most recently from ed16b38 to 679ff67 Compare March 7, 2024 21:02
@jviki jviki force-pushed the sk-constructors branch 5 times, most recently from d6275cc to a146937 Compare March 7, 2024 22:04
@jviki jviki force-pushed the sk-constructors branch 2 times, most recently from ac167cf to b3a64c9 Compare March 7, 2024 22:11
tarcieri
tarcieri reviewed Mar 7, 2024
View reviewed changes
ssh-key/src/private/sk.rs Outdated Show resolved Hide resolved
@jviki jviki force-pushed the sk-constructors branch from b3a64c9 to 37ec369 Compare March 7, 2024 22:13
@jviki jviki force-pushed the sk-constructors branch from 37ec369 to 45a323f Compare March 7, 2024 22:42
tarcieri
tarcieri reviewed Mar 7, 2024
View reviewed changes
ssh-key/src/private/sk.rs Outdated Show resolved Hide resolved
@jviki jviki force-pushed the sk-constructors branch from 45a323f to 9ad171b Compare March 7, 2024 22:45
@jviki jviki force-pushed the sk-constructors branch from 9ad171b to 2d7efe5 Compare March 7, 2024 22:46
@jviki jviki force-pushed the sk-constructors branch from 2d7efe5 to c05f8d3 Compare March 7, 2024 22:47
tarcieri
tarcieri reviewed Mar 7, 2024
View reviewed changes
ssh-key/src/error.rs
@@ -80,6 +80,12 @@ pub enum Error {
/// Version number.
number: u32,
},

/// Byte array is longer than allowed.
TooLong {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably just be Error::FormatEncoding or encoding::Error::Length

tarcieri
tarcieri approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix up the error types

@tarcieri tarcieri merged commit 4d52699 into RustCrypto:master Mar 9, 2024
13 checks passed
@jviki
Copy link
Contributor Author

jviki commented Mar 10, 2024

I'll fix up the error types

Thanks!

@tarcieri tarcieri mentioned this pull request Mar 12, 2024
Merged
@tarcieri tarcieri mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviki @tarcieri