-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh-key: fix parsing comments with whitespace in AuthorizedKeys
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuthorizedKeys
AuthorizedKeys
tarcieri
approved these changes
Sep 5, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 4, 2024
labbott
added a commit
to oxidecomputer/sshauth
that referenced
this pull request
Oct 8, 2024
Brings in fix RustCrypto/SSH#291 and RustCrypto/SSH#289
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
mkeeter
added a commit
to oxidecomputer/SSH
that referenced
this pull request
Oct 15, 2024
Merged
labbott
added a commit
to oxidecomputer/sshauth
that referenced
this pull request
Oct 17, 2024
This brings in fixes RustCrypto/SSH#291 and RustCrypto/SSH#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh_key::PublicKey::read_openssh_file
can read the following key:However, if I treat it as a single-line
authorized_keys
and read it withssh_key::AuthorizedKeys::read_file
, it fails:This is because the
authorized_keys
parser doesn't respect spaces in the comment field, so it's trying to parseecdsa-sha2-nistp256
as the options andhello
as the key material.This PR fixes the issue, and also adds a unit test for
authorized_keys
with whitespace in their comments.