fix: only set blob versioned hashes for 4844 (paradigmxyz#7354)

Ruteri · Apr 17, 2024 · 5f11c65 · 5f11c65
1 parent bdd19d5
commit 5f11c65
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/crates/rpc/rpc-types-compat/src/transaction/mod.rs b/crates/rpc/rpc-types-compat/src/transaction/mod.rs
@@ -77,7 +77,7 @@ fn fill(
 
     // let chain_id = signed_tx.chain_id().map(U64::from);
     let chain_id = signed_tx.chain_id();
-    let mut blob_versioned_hashes = Vec::new();
+    let mut blob_versioned_hashes = None;
 
     #[allow(unreachable_patterns)]
     let access_list = match &mut signed_tx.transaction {
@@ -104,7 +104,7 @@ fn fill(
         )),
         PrimitiveTransaction::Eip4844(tx) => {
             // extract the blob hashes from the transaction
-            blob_versioned_hashes = std::mem::take(&mut tx.blob_versioned_hashes);
+            blob_versioned_hashes = Some(std::mem::take(&mut tx.blob_versioned_hashes));
 
             Some(AccessList(
                 tx.access_list
@@ -148,7 +148,7 @@ fn fill(
         transaction_index,
         // EIP-4844 fields
         max_fee_per_blob_gas: signed_tx.max_fee_per_blob_gas().map(U256::from),
-        blob_versioned_hashes: Some(blob_versioned_hashes),
+        blob_versioned_hashes,
         // Optimism fields
         #[cfg(feature = "optimism")]
         other: OptimismTransactionFields {