Limit orthanc raw storage size #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new variable names are consistent with what is set in `.env` and `test/.env.test`
This reverts commit 0842f43.
* Set orthanc raw maximum storage in Dockerfile * Orthanc raw defaults to no limit on storage Saves us from faffing around with build args for other tests * Format README * Document `ORTHANC_RAW_MAXIMUM_STORAGE_SIZE` * Add simple test for `ORTHANC_RAW_MAXIMUM_STORAGE_SIZE` --------- Co-authored-by: Milan Malfait <[email protected]>
|
Ah woops! Didn't notice the base branch of the previous PR 😅 |
milanmlft
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ah the previous PR was just comparing to the work @milanmlft had already done, so now let's merge it into main!
Closes UCLH-Foundry/the-rolling-skeleton#69
Closes #130