Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use better low-frequency replacement values #115

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

milanmlft
Copy link
Member

@milanmlft milanmlft commented Nov 27, 2024

As requested by IG
Waiting on @SophieMcA for feedback.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (a1e6e0d) to head (8cd22e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   94.31%   94.36%   +0.04%     
==========================================
  Files          23       23              
  Lines         757      763       +6     
==========================================
+ Hits          714      720       +6     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milanmlft milanmlft marked this pull request as draft November 28, 2024 12:57
@milanmlft milanmlft self-assigned this Nov 28, 2024
@milanmlft milanmlft requested a review from stefpiatek November 28, 2024 12:57
@milanmlft milanmlft marked this pull request as ready for review November 28, 2024 13:38
@milanmlft
Copy link
Member Author

Looks like @SophieMcA is happy with this.

Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for getting this in Milan 🙏🏻

app/R/mod_datatable.R Outdated Show resolved Hide resolved
@milanmlft milanmlft merged commit c0a2d8c into main Dec 4, 2024
8 checks passed
@milanmlft milanmlft deleted the milanmlft/new-low-freq-thresholds branch December 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants