Update configure-an-sap-fiori-for-the-abap-platform-job-4c26bfb.md #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing dot, not required and causes issues when pasted into an IDE.
|
@kaylinche @o-liver please review and merge if appropiate. |
|
@SarahLendle Changes look fine from my point of view. Can you please check? |
o-liver
approved these changes
Oct 14, 2024
| @@ -568,7 +568,7 @@ The following steps will introduce [Karma](https://github.com/SAP/karma-ui5), a | |||
| config.set({ | |||
| frameworks: ["ui5"], | |||
| ui5: { | |||
| configPath: "ui5-mock.yaml". // change to ui5.yaml if ui5-mock.yaml does not exist. | |||
| configPath: "ui5-mock.yaml" // change to ui5.yaml if ui5-mock.yaml does not exist. | |||
|
@SarahLendle are you to review and merge please? Thanks |
|
Hi @longieirl! Thanks a lot for your contribution and sorry for the delay due to illness. I've updated the documentation accordingly: https://help.sap.com/docs/continuous-integration-and-delivery/sap-continuous-integration-and-delivery/configure-sap-fiori-for-abap-platform-job-in-job-editor?version=Cloud |
SarahLendle
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove trailing dot, not required and causes issues when pasted into an IDE.