-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Setup instructions #125
Conversation
|
@matz3 and @RandomByte, should we promote global installation or should we try to use |
@@ -116,11 +116,11 @@ You can view and download all files at [Quick Start - Step 1](https://ui5.sap.co | |||
|
|||
7. Open a terminal in the app root folder and execute `npm i -D @ui5/cli` to install UI5 Tooling. | |||
|
|||
8. Execute `ui5 init` in the app root folder. | |||
8. Execute `npx ui5 init` in the app root folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would need to be npx @ui5/cli init
(https://www.npmjs.com/package/@ui5/cli), right? There's no package named ui5
, as it is a scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konnraad feel free to adjust the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think I missed some detail. npx ui5
works fine, if you have the @ui5/cli
package installed in your project. Which is the case in this scenario. But IMO this leads to a lot of confusion (as it already confused me).
npm exec ui5
would be the correct and safe way of invoking the local ui5
binary in a package. This way you don't accidentally try to install the ui5
package. But again, this is then also longer to type.
And our global ui5
CLI invokes the local installation, so there's no downside of having a global and local installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically the command is used more than just once. Therefore, I would still expect that one global install is more user-friendly than having to use |
Thank you for your valuable content contribution, @konnraad! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply. Your user ID is displayed as follows: Change display name for User ID N where N is your user ID. For example, 53 is the user ID of the user 'qmacro'. Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete. |
Implemented from 1.127 |
discussed with @flovogt