Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step-26-mock-server-configuration-bae9d90.md #98

Closed
wants to merge 1 commit into from
Closed

Update step-26-mock-server-configuration-bae9d90.md #98

wants to merge 1 commit into from

Conversation

caiwenhn2008
Copy link

missing =>

Copy link

cla-assistant bot commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

@KlattG KlattG self-requested a review December 6, 2023 14:36
@flovogt
Copy link

flovogt commented Dec 6, 2023

@caiwenhn2008 thanks for creating this issue. Using just a simple method definition should be fine here. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions

Any benefits of using arrow function here?

@caiwenhn2008
Copy link
Author

caiwenhn2008 commented Dec 7, 2023

@caiwenhn2008 thanks for creating this issue. Using just a simple method definition should be fine here. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions

Any benefits of using arrow function here?

Thanks for quick response, below screenshot is what I saw from https://sapui5.hana.ondemand.com/sdk/#/topic/bae9d90d2e9c4206889368f04edab508 , and I failed when running this sample due to extra colon

image

is there any github synch issue here? I think we can either remove ":" or change to " init: () => {"
"

@flovogt
Copy link

flovogt commented Dec 7, 2023

Ok, i just figured out that I have fixed it already.

See here https://sdk.openui5.org/nightly/#/topic/bae9d90d2e9c4206889368f04edab508

@KlattG could you please check if the fix is also present in the last 1.120 version?

@caiwenhn2008
Copy link
Author

Yes, nightly fixed, thanks!

@OlMue
Copy link
Contributor

OlMue commented Dec 7, 2023

@KlattG could you please check if the fix is also present in the last 1.120 version?

Just checked it, it's fixed in 1.120.2.

@OlMue OlMue added contribution Valuable Contribution type/incorrect-statement Statements in the documentation are incorrect. labels Dec 7, 2023
Copy link

sap-doc-bot bot commented Dec 7, 2023

Thank you for your valuable content contribution, @caiwenhn2008! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@KlattG KlattG removed their request for review December 8, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution type/incorrect-statement Statements in the documentation are incorrect.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants