Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide up__ID in change tracking view #379

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

vmikhailenko
Copy link
Contributor

Cosmetic change: this change hides the up__ID from the change history view.

@vmikhailenko
Copy link
Contributor Author

Bildschirmfoto 2024-10-09 um 11 30 26

@vmikhailenko
Copy link
Contributor Author

Unrelated: Am I seeing things, or we no longer ignore package-lock.json under app? Every time I run mbt build, they are recreated. Shouldn't they be ignored?

@vmikhailenko vmikhailenko reopened this Oct 9, 2024
@mofterdinger mofterdinger self-requested a review October 9, 2024 10:11
Copy link
Member

@mofterdinger mofterdinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-)

@mofterdinger
Copy link
Member

Unrelated: Am I seeing things, or we no longer ignore package-lock.json under app? Every time I run mbt build, they are recreated. Shouldn't they be ignored?

I experienced the same. I wonder if these package.json are really required ? They don't have any dependencies:

{
  "name": "browse",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}

Even the main script index.js doesn't exist. I think we can ignore the corresponding package-lock.json.

@vmikhailenko
Copy link
Contributor Author

Unrelated: Am I seeing things, or we no longer ignore package-lock.json under app? Every time I run mbt build, they are recreated. Shouldn't they be ignored?

I experienced the same. I wonder if these package.json are really required ? They don't have any dependencies:

{
  "name": "browse",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}

Even the main script index.js doesn't exist. I think we can ignore the corresponding package-lock.json.

Witchcraft. This no longer happens. :(

@vmikhailenko vmikhailenko merged commit ca592b0 into main Oct 9, 2024
3 checks passed
@vmikhailenko vmikhailenko deleted the ui-remove-up__ID-from-change-history branch October 9, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants