Merge pull request #13 from SAP-samples/refactor/exercises-remove-todos

refactor(exercises): remove TS based todo comments
SAP-samples · Jan 24, 2025 · 42c171b · 42c171b
2 parents f1181a4 + c8adf70
commit 42c171b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 6 deletions.
diff --git a/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex04/sample.p13n/webapp/control/P13nTable.ts
@@ -1,7 +1,6 @@
 import Table, { $TableSettings } from "sap/m/Table"
 import Engine, { State } from "sap/m/p13n/Engine"
 import SelectionController from "sap/m/p13n/SelectionController"
-// @ts-ignore TODO: FIX export of MetadataObject type
 import MetadataHelper, { MetadataObject } from "sap/m/p13n/MetadataHelper"
 import Column from "sap/m/Column"
 import Text from "sap/m/Text"
@@ -24,7 +23,6 @@ export default class P13nTable extends Table {
 
 	constructor(id?: string, settings?: $TableSettings) {
 		super(id, settings)
-		// @ts-ignore  TODO: FIX static method declaration
 		this.engine = Engine.getInstance()
 		this.initialized = new Promise((resolve: () => void): void => {
 			this.attachEventOnce("updateFinished", (): void => {
@@ -47,13 +45,11 @@ export default class P13nTable extends Table {
 			}
 		})
 
-		// @ts-ignore TODO: FIX constructor
 		this.helper = new MetadataHelper(columnsMetadata)
 
 		this.engine.register(this, {
 			helper: this.helper,
 			controller: {
-				// @ts-ignore TODO: FIX constructor
 				Columns: new SelectionController({
 					control: this,
 					targetAggregation: "columns"

diff --git a/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex06/sample.p13n/webapp/control/P13nTable.ts
@@ -33,7 +33,6 @@ export default class P13nTable extends Table {
 
 	constructor(id?: string, settings?: $TableSettings) {
 		super(id, settings)
-		// @ts-ignore  TODO: FIX static method declaration
 		this.engine = Engine.getInstance()
 		this.initialized = new Promise((resolve: () => void): void => {
 			this.attachEventOnce("updateFinished", (): void => {

diff --git a/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts b/exercises/ex09/sample.p13n/webapp/control/P13nTable.ts
@@ -33,7 +33,6 @@ export default class P13nTable extends Table {
 
 	constructor(id?: string, settings?: $TableSettings) {
 		super(id, settings)
-		// @ts-ignore  TODO: FIX static method declaration
 		this.engine = Engine.getInstance()
 		this.initialized = new Promise((resolve: () => void): void => {
 			this.attachEventOnce("updateFinished", (): void => {