Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SapMachine #1657: Reenable logging test #1658

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

RealCLanger
Copy link
Member

After JDK-8327098 went in upstream, we can reenable gtest TEST(LogSelectionList, combination_limit).

fixes #1657

@SapMachine
Copy link
Member

Hello @RealCLanger, this pull request fulfills all formal requirements.

Copy link
Member

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealCLanger RealCLanger merged commit ae91190 into SAP:sapmachine Apr 29, 2024
96 of 98 checks passed
@RealCLanger RealCLanger deleted the reenableloggingtest branch April 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce SapMachine diffs to upstream
4 participants