fix(styles): change the default line height to normal [ci visual]

SAP · Nov 27, 2023 · 116e90d · 116e90d
1 parent b81e3d4
commit 116e90d
Show file tree

Hide file tree

Showing 4 changed files with 543 additions and 9 deletions.
diff --git a/packages/styles/src/mixins/_mixins.scss b/packages/styles/src/mixins/_mixins.scss
@@ -3,7 +3,7 @@
 // utils
 @mixin fd-reset {
   font-size: var(--sapFontSize);
-  line-height: var(--sapContent_LineHeight);
+  line-height: normal;
   color: var(--sapTextColor);
   font-family: var(--sapFontFamily);
   font-weight: normal;

diff --git a/packages/styles/src/progress-indicator.scss b/packages/styles/src/progress-indicator.scss
@@ -248,32 +248,31 @@ $fd-progress-indicator-states: (
 
   &__overflow {
     @include fd-reset();
+    @include fd-set-paddings-y-equal(0.25rem);
+    @include fd-set-paddings-x(0.5rem, 0);
 
     @include fd-flex-vertical-center() {
+      gap: 0.5rem;
       justify-content: space-between;
     }
 
-    @include fd-set-padding-left(0.5rem);
-
     overflow: hidden;
     white-space: normal;
     max-width: 95vw;
   }
 
   &__overflow-close {
     @include fd-reset();
-    @include fd-set-margin-left(0.5rem);
+    @include fd-flex-center();
+    @include fd-set-width(1.4375rem);
+    @include fd-set-height(1.375rem);
 
     @include fd-focus() {
       outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
     }
 
     cursor: pointer;
-    width: 1.4375rem;
-    height: 1.375rem;
-    margin: 0.125rem;
     text-align: center;
-    line-height: 1.6rem;
     background: transparent;
 
     [class*='sap-icon'] {

diff --git a/packages/styles/src/quick-view.scss b/packages/styles/src/quick-view.scss
@@ -27,6 +27,10 @@ $fd-quick-view-group-item-indent: 0.75rem;
     padding: 1rem;
     background-color: var(--sapGroup_ContentBackground);
 
+    .#{$fd-namespace}-form-item {
+      gap: 0.25rem;
+    }
+
     .#{$fd-namespace}-bar {
       padding: 0;
 
@@ -50,15 +54,20 @@ $fd-quick-view-group-item-indent: 0.75rem;
   }
 
   &__subheader-text {
+    @include fd-flex(column) {
+      gap: 0.25rem;
+      justify-content: center;
+    }
+
     max-width: 100%;
+    height: 100%;
     min-width: 0; // fix for flex width https://github.com/philipwalton/flexbugs#flexbug-17
   }
 
   &__subtitle {
     @include fd-reset();
     @include fd-ellipsis();
 
-    margin-top: 0.25rem;
     color: var(--sapTile_TextColor);
   }