Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved btp button examples into the BTP subfolder #4925

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

g-cheishvili
Copy link
Contributor

@g-cheishvili g-cheishvili commented Oct 25, 2023

Related Issue

Closes SAP/fundamental-styles#

Description

Moved BTP button examples to the separate sub-section for the BTP components and added restrictions on tool-header badge contents

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit c7c3cba
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/6538ec0adf5b4d00082b9dae
😎 Deploy Preview https://deploy-preview-4925--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 5048e95
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/6539777b0dbe3c000825790d
😎 Deploy Preview https://deploy-preview-4925--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@g-cheishvili g-cheishvili force-pushed the btp_button_separation branch from 630f052 to e4c4a98 Compare October 25, 2023 11:01
@InnaAtanasova InnaAtanasova added the BTP BTP design label Oct 25, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 124 milestone Oct 25, 2023
@g-cheishvili g-cheishvili force-pushed the btp_button_separation branch from e4c4a98 to 9b79016 Compare October 25, 2023 17:24
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of badge (red solid circle) can't be used with other types of buttons. It can be used only with Tool Header button

@g-cheishvili g-cheishvili force-pushed the btp_button_separation branch from 9b79016 to 5048e95 Compare October 25, 2023 20:15
@g-cheishvili g-cheishvili changed the title fix: added btp modifier to button chore: moved btp button examples into the BTP subfolder Oct 25, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 124, Sprint 125 Oct 27, 2023
@droshev droshev merged commit b54bee9 into main Oct 27, 2023
8 checks passed
@droshev droshev deleted the btp_button_separation branch October 27, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTP BTP design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants