Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common-css): change the common-css package #4928

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(common-css): change the common-css package #4928

merged 1 commit into from
Oct 25, 2023

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Oct 25, 2023

BREAKING CHANGE:
move package @fundamental-styles/common-css to @sap-ui/common-css

@droshev droshev added this to the Sprint 124 milestone Oct 25, 2023
@droshev droshev self-assigned this Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit a2b37a6
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/65398a9d7b3c590008e0e9f4
😎 Deploy Preview https://deploy-preview-4928--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@petermuessig
Copy link

LGTM

@droshev droshev merged commit 9e7f2a1 into main Oct 25, 2023
8 checks passed
@droshev droshev deleted the fix/change-common-css-package branch October 25, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

Assignees

@droshev droshev

Labels
tooling
Projects
None yet
Milestone
Sprint 124
Development

Successfully merging this pull request may close these issues.
3 participants
@droshev @petermuessig @mikerodonnell89