[WIP]fix(styles): horizontal nav a11y #5087
Closed
+237
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
N1XUS
changed the title
| @@ -1,19 +1,18 @@ | |||
| <div style="height: 500px"> | |||
| <nav class="fd-navigation fd-navigation--horizontal" aria-label="Horizontal Navigation"> | |||
| <div class="fd-navigation__container"> | |||
| <ul class="fd-navigation__list" role="menubar" aria-label="Horizontal Navigation"> | |||
| <ul class="fd-navigation__list" role="tablist" aria-orientation="horizontal" aria-label="Horizontal Navigation"> | |||
There was a problem hiding this comment.
the default aria-orientation for role="tablist" is horizontal, you don't need to specify it (just FYI)
| > | ||
| <div | ||
| class="fd-navigation__item" | ||
| aria-current="page" | ||
| aria-selected="false" | ||
| aria-expanded="false" | ||
| role="menuitem" | ||
| role="tab" |
There was a problem hiding this comment.
Role tab needs the following:
- aria-labelledby: this should be leading to the span that wraps the text
- aria-controls: referring to the tabpanel that the tab controls
- aria-posinset and aria-setsize
- aria-selected
- aria-expanded
- aria-haspopup: if the tab has a popup menu
There was a problem hiding this comment.
| > | ||
| <div | ||
| class="fd-navigation__item" | ||
| aria-current="page" | ||
| aria-selected="false" | ||
| aria-expanded="false" | ||
| role="menuitem" | ||
| role="tab" | ||
| > | ||
| <a class="fd-navigation__link" role="link" href="#"> |
There was a problem hiding this comment.
in this case, since we now have Tabs, I am not sure if we need the role link and the href
There was a problem hiding this comment.
Well, technically it's still a navigation, and link can be applied to it, no?
|
waiting for the signed off a11y design spec |
droshev
changed the title
|
can be reopened once the a11y design spec is finalized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes none
Description