Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): splitter horizontal scrolls on active handle #5088

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

g-cheishvili
Copy link
Contributor

Related Issue

Closes SAP/fundamental-styles#

Description

Splitter decorations were overflowing the splitter resizer because they had width: 100% in active state. This fix makes them flex-grow instead

Screenshots

Before:

Screenshot 2024-01-03 at 16 44 04

After:

Screenshot 2024-01-03 at 16 44 35

@g-cheishvili g-cheishvili added Bug Something isn't working BTP BTP design labels Jan 3, 2024
@g-cheishvili g-cheishvili added this to the Sprint 128 milestone Jan 3, 2024
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 198faff
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/65955ce573860d0009ff24fd
😎 Deploy Preview https://deploy-preview-5088--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@g-cheishvili g-cheishvili merged commit af06dee into main Jan 3, 2024
13 checks passed
@g-cheishvili g-cheishvili deleted the splitter-horizontal-scrolls branch January 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTP BTP design Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants