Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update Notifications for VEGA [ci visual] #5892

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes none

Description

update Notifications per VEGA from Dec 19, 2024

BREAKING CHANGES

  • removed class fd-notification--banner
  • added a container with class fd-notification-banner to wrap banner notifications

Before:

<div class="fd-notification fd-notification--banner" tabindex="0">
    <div class="fd-notification__body">...</div>
    ......
</div>

After:

<div class="fd-notification-banner">
    <div class="fd-notification" tabindex="0">
        <div class="fd-notification__body">...</div>
        ......
    </div>
    <div class="fd-notification" tabindex="0">
        <div class="fd-notification__body">...</div>
        ......
    </div>
</div>

@InnaAtanasova InnaAtanasova requested a review from a team January 13, 2025 19:38
@InnaAtanasova InnaAtanasova self-assigned this Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit ca9ca27
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/678570881d8efe0008dc9462
😎 Deploy Preview https://deploy-preview-5892--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova force-pushed the fix/notigications-vega-updates branch from 26603a4 to ca9ca27 Compare January 13, 2025 19:59
@InnaAtanasova InnaAtanasova merged commit 669e7e1 into main Jan 16, 2025
10 checks passed
@InnaAtanasova InnaAtanasova deleted the fix/notigications-vega-updates branch January 16, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants