fix: Fix testing leftovers

SAP · Feb 4, 2025 · 658be06 · 658be06
1 parent ef64f1c
commit 658be06
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/linter/binding/BindingLinter.ts b/src/linter/binding/BindingLinter.ts
@@ -143,9 +143,7 @@ export default class BindingLinter {
 			}
 		} catch (err) {
 			const message = err instanceof Error ? err.message : String(err);
-			if (err instanceof Error) {
-				this.#context.addLintingMessage(this.#resourcePath, MESSAGE.PARSING_ERROR, {message}, position);
-			}
+			this.#context.addLintingMessage(this.#resourcePath, MESSAGE.PARSING_ERROR, {message}, position);
 		}
 	}
 

diff --git a/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js b/test/fixtures/linter/rules/NoGlobals/FormatterGlobalBindingString.js
@@ -12,7 +12,7 @@ sap.ui.define(
 		// Although the formatter property does not look like a global notation,
 		// it should still be detected if it is a string:
 		const input2 = new Input({
-			value: "{ path: 'invoice>Status', formatter: formatter.statusText }"
+			value: "{ path: 'invoice>Status', formatter: 'formatter.statusText' }"
 		});
 	}
 );
diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.md b/test/lib/linter/rules/snapshots/NoGlobals.ts.md
@@ -36,7 +36,7 @@ Generated by [AVA](https://avajs.dev).
       {
         coverageInfo: [],
         errorCount: 3,
-        fatalErrorCount: 1,
+        fatalErrorCount: 0,
         filePath: 'FormatterGlobalBindingString.js',
         messages: [
           {
@@ -57,11 +57,10 @@ Generated by [AVA](https://avajs.dev).
           },
           {
             column: 11,
-            fatal: true,
             line: 15,
-            message: 'Expected \'a\' instead of \'o\'',
-            messageDetails: 'Check the source file for syntax errors',
-            ruleId: 'parsing-error',
+            message: 'Access of global variable \'formatter\' (formatter.statusText)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
+            ruleId: 'no-globals',
             severity: 2,
           },
         ],

diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.snap b/test/lib/linter/rules/snapshots/NoGlobals.ts.snap