feat: Add global detection for XML Templating #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
feat-detect-xml-templating-globals
branch
from
8eb3ce4 to
28701d2
Compare
matz3
force-pushed
the
feat-detect-xml-templating-globals
branch
2 times, most recently
from
ff4a39b to
bb0bd34
Compare
matz3
commented
Feb 11, 2025
Comment on lines
+376
to
+379
| message: ({moduleNames}: {moduleNames: string}) => | ||
| `Usage of space-separated list '${moduleNames}' in template:require`, | ||
| details: () => `Use the object notation of template:require instead ` + | ||
| `{@link topic:263f6e5a915f430894ee290040e7e220}`, |
There was a problem hiding this comment.
@KlattG please review this new message
d3xter666
previously approved these changes
Feb 13, 2025
matz3
force-pushed
the
feat-detect-xml-templating-globals
branch
from
6c2d8d4 to
79ea964
Compare
matz3
force-pushed
the
feat-detect-xml-templating-globals
branch
from
79ea964 to
1afb25a
Compare
JIRA: CPOUI5FOUNDATION-917
JIRA: CPOUI5FOUNDATION-917
matz3
force-pushed
the
feat-detect-xml-templating-globals
branch
from
1afb25a to
a840e1f
Compare
d3xter666
reviewed
Feb 14, 2025
| <template:with path="field>Value/$Path" var="target"> | ||
|
|
||
| <!-- Global access via computed annotation - no arguments, expression binding template:if --> | ||
| <template:if test="{= ${target>@@sap.ui.model.odata.v4.AnnotationHelper.getValueListType} !== 'None' }"> |
There was a problem hiding this comment.
Suggested change
| <template:if test="{= ${target>@@sap.ui.model.odata.v4.AnnotationHelper.getValueListType} !== 'None' }"> | |
| <template:if test="{= ${target>@@sap.ui.model.odata.v4.AnnotationHelper.getValueListType} !== 'None' }"> |
It's just a question as I cannot reason myself, but is this intentionally missed in the snapshots?
Line #23 is reported, but not this one
There was a problem hiding this comment.
It's an expression binding, which creates "parts" that are not checked, yet. This will be done in a separate PR.
| <template:else> | ||
|
|
||
| <!-- Global access via computed annotation - no arguments, composite binding --> | ||
| <Text text="ValueListType: {field>@@sap.ui.model.odata.v4.AnnotationHelper.getValueListType}" /> |
There was a problem hiding this comment.
The same as above. Why is that not reported? Is it because of the binding + text inside?
There was a problem hiding this comment.
It's a composite binding, which creates "parts" that are not checked, yet. This will be done in a separate PR.
d3xter666
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-917