-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Detect inline XML fragments & views (reuse TS program) #519
base: main
Are you sure you want to change the base?
Conversation
5205e53
to
ae136f2
Compare
a196c8b
to
480249c
Compare
Currently, the linting results are deterministic and we should stick with that. Only sorting the results when comparing within unit tests will not lead to deterministic results for public consumers. I suspect that this is caused by a missing sorting of the newly created files. For the initial files, this is done via: ui5-linter/src/linter/ui5Types/TypeLinter.ts Lines 87 to 88 in 70ad529
|
Actually, the issue is not in the newly created files, because they are not part of the output, but their findings are injected into (maybe) already existing results in certain files. |
JIRA: CPOUI5FOUNDATION-986
This is alternative implementation of #517 by reusing
program
instead of TS transpiling file by file.Note: This change's base is currently #518 as it paves the ground for dynamic addition of resources to the TS program