Fix unused variable warning introduced by #446 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aiden Woodruff <[email protected]>
cwsmith
approved these changes
Sep 13, 2024
|
@onkarsahni Do you have any insights in terms of Capstone and periodic meshes? Is that something they might support in the future? If we remove the |
|
We have not yet received input, but I am going to merge this for now since it suppresses the compilation warning without further judgement calls. |
flagdanger
pushed a commit
to jacobmerson/core
that referenced
this pull request
Nov 22, 2024
Suppress warning by casting to void. Signed-off-by: Aiden Woodruff <[email protected]>
flagdanger
pushed a commit
to jacobmerson/core
that referenced
this pull request
Nov 22, 2024
Suppress warning by casting to void. Signed-off-by: Aiden Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unused variable warning introduced by #446
This fixes an unused warning when CMake is given
-DENABLE_CAPSTONEby casting to void.However, I wonder if we can remove the
#ifndefaltogether? Currently we expect Capstone meshes to never be periodic. But if they are periodic, I would expect we might want to do the recalculation.