Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe: dimension loops from [0:mesh.dim()] (inclusive) #83

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

cwsmith
Copy link

@cwsmith cwsmith commented Feb 6, 2024

The output for a 2d mesh listed 'entity type: edge' and didn't show the face/triangle count. Likewise for 3d. This PR changes the loop bounds to include mesh.dim().

@Angelyr Angelyr self-requested a review February 6, 2024 19:26
Copy link
Collaborator

@Angelyr Angelyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwsmith cwsmith merged commit 08e643b into master Feb 6, 2024
8 checks passed
@cwsmith cwsmith deleted the cws/describeDim branch February 6, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants