redirection phone or email #225
Conversation
|
Code Climate has analyzed commit e659be6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 30.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 83.4% (-0.3% change). View more on Code Climate. |
| public void openEmailOrPhone(View view){ | ||
| if(!advertiserUser.getPhoneNumber().isEmpty()) { | ||
| AlertDialog.Builder builder = new AlertDialog.Builder(this); | ||
| builder.setTitle("How did you prefer contact the announcer ?"); |
There was a problem hiding this comment.
In refactor PR next week this sentence should be changed to present. And maybe something shorter
There was a problem hiding this comment.
yes absolutely!
| int permissionCheck = ContextCompat.checkSelfPermission(this, Manifest.permission.CALL_PHONE); | ||
| if (permissionCheck != PackageManager.PERMISSION_GRANTED) { | ||
| ActivityCompat.requestPermissions( | ||
| this, | ||
| new String[]{Manifest.permission.CALL_PHONE}, | ||
| 123); | ||
| } else { |
There was a problem hiding this comment.
Maybe in a refactor PR we could modify this code to follow the same way it is structured in other cases where we ask for permissions
There was a problem hiding this comment.
Good catch @rovati ! This should be implemented in the PermissionRequest. Other thing to add to the final refactor.
Content
This PR refer to the issue #213. I modify the simple user activity for allowing the user contact the announcer via phone or email. If the phone number is not present when we click the contact user button, you will directly redirected on the mail service else you will ask via a Alert dialog if you prefer contact the announcer via phone or via email.
Demo
Registrazione.schermo.2021-05-27.alle.16.41.09.mov