Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/directions page #208

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Feature/directions page #208

wants to merge 7 commits into from

Conversation

rbslm
Copy link
Contributor

@rbslm rbslm commented Feb 19, 2025

🛠 Proposed Changes:

Implement navigation to directions feature

📝 Details:

  • Reduce the size of the SearchBarWidget for a more compact layout
  • Implemented the SourceDestinationBox widget to display both Source and Destination input fields
  • Added the Directions feature in BuildingInfoDrawer, which navigates to OutdoorLocationMapView with the selected building pre-filled in the Destination field

gifgit

🔗 Related Issue(s):

@rbslm rbslm requested review from Niravanaa and MeSumo February 19, 2025 00:42
@Niravanaa
Copy link
Contributor

@rbslm Do we intend on the user being able to continously push new OutdoorLocationMapView's pages

I am able to create more than one of that page after selecting the "Get Directions" button from the drawer, but to return to the main menu, I need to press back the number of times I created the pages.

Should I not be able to press back and be instantly returned to the main menu, regardless of the number of "Get Directions" pressed?

@Niravanaa
Copy link
Contributor

Niravanaa commented Feb 22, 2025

There seems to be an issue when my device's location is near a campus, and that the map displays accordingly, and that I attempt to get the Directions to a building, and press back after, I get a Black Screen that prevents me from getting back into the home page or that initial map that gets loaded.

  1. Set device location to be near LOY or SGW campus.
  2. Open the app and have the map rendered into the screen, as intended.
  3. Press on a building and press "Directions" to open the new directions view.
  4. Press on the back arrow to return to the original rendered map
  5. Obtain a black screen, preventing further use of the application.

I would like @MeSumo or @rbslm to reproduce if this is just on my end or not.

I will adjust this in the mean-time on my own.

@Niravanaa Niravanaa self-assigned this Feb 22, 2025
@rbslm
Copy link
Contributor Author

rbslm commented Feb 22, 2025

There seems to be an issue when my device's location is near a campus, and that the map displays accordingly, and that I attempt to get the Directions to a building, and press back after, I get a Black Screen that prevents me from getting back into the home page or that initial map that gets loaded.

  1. Set device location to be near LOY or SGW campus.
  2. Open the app and have the map rendered into the screen, as intended.
  3. Press on a building and press "Directions" to open the new directions view.
  4. Press on the back arrow to return to the original rendered map
  5. Obtain a black screen, preventing further use of the application.

I would like @MeSumo or @rbslm to reproduce if this is just on my end or not.

I will adjust this in the mean-time on my own.

This was fixed using Navigator.pushAndRemoveUntil() instead of Navigator.pushReplacement().
When pressing back, it returns to the current campus map, with the initial building drawer.
If I have pressed back all the way to the main menu before, when pressing back on the map, it navigates to the main menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants