[feat] Balloon 컴포넌트 구현 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
reviewed
Jan 15, 2025
app/src/main/java/org/android/bbangzip/presentation/component/balloon/BalloonContainer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/android/bbangzip/presentation/component/balloon/BottomTailBalloon.kt
Show resolved
Hide resolved
| Icon( | ||
| imageVector = ImageVector.vectorResource(R.drawable.ic_balloon_tail_down), | ||
| contentDescription = null, | ||
| modifier = Modifier.padding(start = 24.dp), |
There was a problem hiding this comment.
p2 여기는 기기대응 고려해서 수정해야 할 것 같아요! 말풍선 너비 계산해서.. Modifier.onSizeChanged 이용하는 방안에 대해서 고민해보세요
| contentDescription = null, | ||
| modifier = Modifier.padding(start = 24.dp), | ||
| tint = BbangZipTheme.colors.staticWhite_FFFFFF, | ||
| ) |
|
|
||
| Spacer(modifier = Modifier.height(10.dp)) | ||
|
|
||
| BottomTailBalloon( |
There was a problem hiding this comment.
p5 BottomTailBallon인데 여기 프리뷰 달아서.. 조금 불편하다고 할 수 있습니다
| @@ -63,3 +64,13 @@ fun Modifier.dropShadow( | |||
| canvas.restore() | |||
| } | |||
| } | |||
|
|
|||
| @Composable | |||
| fun Modifier.applyShadows( | |||
| shape: Shape, | ||
| ): Modifier { | ||
| return shadowType.shadowOptions.fold(this) { acc, shadowOption -> | ||
| acc.dropShadow(shape = shape, color = shadowOption.color, blur = shadowOption.blur, offsetY = shadowOption.offsetY, offsetX = shadowOption.offsetX, spread = shadowOption.spread) |
There was a problem hiding this comment.
p4 이거 인자 하나마다 한 줄 씩 띄어쓰기 해주면 가독성이 더 좋아지겠어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
ballon 컴포넌트를 구현했습니다. 사용씨 horizontalPadding 넣는걸 기억해주세요!