chore(playlist-plugin): use dynamic repeat mode length in toggle calc…

…ulation Replaced hardcoded value '3' to improve maintainability and adapt to changes in RepeatMode.
SRGSSR · Oct 22, 2024 · 8d5daf4 · 8d5daf4
1 parent 5ac7050
commit 8d5daf4
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/pillarbox-playlist/src/pillarbox-playlist.js b/packages/pillarbox-playlist/src/pillarbox-playlist.js
@@ -82,7 +82,7 @@ export class PillarboxPlaylist extends Plugin {
    *        If omitted, the repeat mode will cycle in order through: no repeat, repeat all and repeat one.
    */
   toggleRepeat(force = undefined) {
-    this.repeat = force ?? (this.repeat + 1) % 3;
+    this.repeat = force ?? (this.repeat + 1) % Object.keys(RepeatMode).length;
   }
 
   /**

diff --git a/packages/pillarbox-playlist/test/pillarbox-playlist.spec.js b/packages/pillarbox-playlist/test/pillarbox-playlist.spec.js
@@ -404,6 +404,28 @@ describe('PillarboxPlaylist', () => {
       expect(srcSpy).toHaveBeenLastCalledWith(playlist[0].sources);
       expect(posterSpy).toHaveBeenLastCalledWith(playlist[0].poster);
     });
+
+    it('should toggle repeat mode', () => {
+      pillarboxPlaylist.toggleRepeat(RepeatMode.NO_REPEAT);
+
+      pillarboxPlaylist.toggleRepeat();
+      expect(pillarboxPlaylist.repeat).toBe(RepeatMode.REPEAT_ALL);
+      expect(pillarboxPlaylist.isNoRepeatMode()).toBeFalsy();
+      expect(pillarboxPlaylist.isRepeatAllMode()).toBeTruthy();
+      expect(pillarboxPlaylist.isRepeatOneMode()).toBeFalsy();
+
+      pillarboxPlaylist.toggleRepeat();
+      expect(pillarboxPlaylist.repeat).toBe(RepeatMode.REPEAT_ONE);
+      expect(pillarboxPlaylist.isNoRepeatMode()).toBeFalsy();
+      expect(pillarboxPlaylist.isRepeatAllMode()).toBeFalsy();
+      expect(pillarboxPlaylist.isRepeatOneMode()).toBeTruthy();
+
+      pillarboxPlaylist.toggleRepeat();
+      expect(pillarboxPlaylist.repeat).toBe(RepeatMode.NO_REPEAT);
+      expect(pillarboxPlaylist.isNoRepeatMode()).toBeTruthy();
+      expect(pillarboxPlaylist.isRepeatAllMode()).toBeFalsy();
+      expect(pillarboxPlaylist.isRepeatOneMode()).toBeFalsy();
+    });
   });
 
   describe('shuffle', () => {