Tests: Add passkey test cases for following scenario #6965

madhuriupadhye · 2023-09-29T15:47:41Z

Test cases are as follows:
7. Check offline authentication of a user with LDAP, IPA, AD and Samba
8. Fetch user from cache for LDAP, IPA, AD and Samba server
9. Check authentication of user when multiple keys added for same user with LDAP, IPA, AD and Samba server.
10. Check authentication of user when same key added for multiple user with LDAP, IPA, AD and Samba server.

ikerexxe

Why do you need to set cache_credentials and krb5_store_password_if_offline to true? Offline authentication should work without changing these options.

spoore1

So far, just some minor things to start looking at. Overall it looks good.

src/tests/system/tests/test_passkey.py

madhuriupadhye · 2023-10-06T15:03:55Z

Why do you need to set cache_credentials and krb5_store_password_if_offline to true? Offline authentication should work without changing these options.

I took reference from https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html/configuring_authentication_and_authorization_in_rhel/assembly_additional-configuration-for-identity-and-authentication-providers_configuring-authentication-and-authorization-in-rhel for cache_credentials and offline_credentials_expiration

and

for krb5_store_password_if_offline https://sssd.io/design-pages/pam_conversation_for_otp.html, under section offline authentication.

ikerexxe · 2023-10-19T10:35:47Z

I took reference from https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html/configuring_authentication_and_authorization_in_rhel/assembly_additional-configuration-for-identity-and-authentication-providers_configuring-authentication-and-authorization-in-rhel for cache_credentials and offline_credentials_expiration

cache_credentials needs to be clarified so I opened #6989. offline_credentials_expiration is set to 0 which means no limit, so no need to set it.

for krb5_store_password_if_offline https://sssd.io/design-pages/pam_conversation_for_otp.html, under section offline authentication.

That's only valid for 2FA, and from the SSSD perspective this isn't 2FA. The pin (or fingerprint) that you are setting is handled by FIDO2. Therefore, it is not necessary to set this value either.

spoore1

Quick review update. Small things like adding su to the descriptions to match other comments from #6727

src/tests/system/tests/test_passkey.py

spoore1

Just one new question/comment.

src/tests/system/tests/test_passkey.py

spoore1

Minor comments.

src/tests/system/tests/test_passkey.py

spoore1

LGTM

ikerexxe

Comments inline.

src/tests/system/tests/test_passkey.py

ikerexxe

LGTM! Good job

justin-stephenson

Ack, thank you Madhuri.

spoore1

LGTM.

Test cases are as follows: 7. Check offline authentication of a user with LDAP, IPA, AD and Samba 8. Fetch user from cache for LDAP, IPA, AD and Samba server 9. Check authentication of user when multiple keys added for same user with LDAP, IPA, AD and Samba server. 10. Check authentication of user when same key added for multiple user with LDAP, IPA, AD and Samba server. Signed-off-by: Madhuri Upadhye <[email protected]>

jakub-vavra-cz · 2024-01-05T13:54:02Z

@pbrezina Could You please merge this? Due to binary data the merge script does not work there.

pbrezina · 2024-01-08T11:14:12Z

master
- 173f311 - Tests: Add passkey test cases for following scenario
sssd-2-9
- 80d5a34 - Tests: Add passkey test cases for following scenario

madhuriupadhye added the Tests label Sep 29, 2023

madhuriupadhye marked this pull request as draft September 29, 2023 15:53

madhuriupadhye force-pushed the test_passkey_part3 branch from d4d1573 to 561e06c Compare October 1, 2023 05:46

madhuriupadhye requested a review from ikerexxe October 1, 2023 05:46

madhuriupadhye added the Waiting for review label Oct 1, 2023

madhuriupadhye marked this pull request as ready for review October 1, 2023 05:48

madhuriupadhye added the passkey Issues and PRs related to 'passkey' feature label Oct 1, 2023

ikerexxe reviewed Oct 2, 2023

View reviewed changes

andreboscatto assigned ikerexxe and spoore1 Oct 3, 2023

andreboscatto requested a review from spoore1 October 3, 2023 12:39

spoore1 reviewed Oct 5, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part3 branch 3 times, most recently from e83f26d to e709956 Compare October 10, 2023 07:16

spoore1 reviewed Nov 22, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part3 branch 2 times, most recently from e709956 to 7c7e55d Compare November 27, 2023 09:00

github-advanced-security bot found potential problems Nov 27, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Fixed Show fixed Hide fixed

madhuriupadhye force-pushed the test_passkey_part3 branch from 7c7e55d to ce8587d Compare November 27, 2023 09:13

spoore1 reviewed Nov 29, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part3 branch 3 times, most recently from f450bc7 to ebf6a03 Compare December 1, 2023 16:15

spoore1 reviewed Dec 1, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

madhuriupadhye force-pushed the test_passkey_part3 branch from ebf6a03 to 3cd756b Compare December 13, 2023 14:48

spoore1 approved these changes Dec 13, 2023

View reviewed changes

spoore1 self-requested a review December 13, 2023 16:29

madhuriupadhye force-pushed the test_passkey_part3 branch from 3cd756b to 8a9a935 Compare December 13, 2023 16:39

ikerexxe requested changes Dec 14, 2023

View reviewed changes

madhuriupadhye force-pushed the test_passkey_part3 branch from 8a9a935 to 274ca4a Compare December 14, 2023 14:02

madhuriupadhye requested a review from ikerexxe December 14, 2023 14:04

madhuriupadhye force-pushed the test_passkey_part3 branch 2 times, most recently from dcdd33f to b313042 Compare December 14, 2023 16:22

ikerexxe mentioned this pull request Dec 15, 2023

roles: add passkeyUser objectClass only once SSSD/sssd-test-framework#66

Merged

justin-stephenson reviewed Dec 15, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

justin-stephenson reviewed Dec 15, 2023

View reviewed changes

src/tests/system/tests/test_passkey.py Outdated Show resolved Hide resolved

justin-stephenson self-assigned this Dec 15, 2023

madhuriupadhye force-pushed the test_passkey_part3 branch from b313042 to cb40b76 Compare December 18, 2023 16:02

madhuriupadhye requested a review from justin-stephenson December 18, 2023 16:04

madhuriupadhye force-pushed the test_passkey_part3 branch from cb40b76 to 405dee8 Compare December 18, 2023 16:06

ikerexxe approved these changes Dec 19, 2023

View reviewed changes

madhuriupadhye force-pushed the test_passkey_part3 branch from 405dee8 to d4148c8 Compare December 19, 2023 08:59

justin-stephenson approved these changes Dec 19, 2023

View reviewed changes

spoore1 approved these changes Dec 19, 2023

View reviewed changes

ikerexxe added Accepted backport-to-stable and removed Waiting for review labels Dec 20, 2023

madhuriupadhye force-pushed the test_passkey_part3 branch from 9aa3ada to d6deb1a Compare January 2, 2024 11:14

jakub-vavra-cz added Ready to push Ready to push and removed Ready to push Ready to push labels Jan 5, 2024

pbrezina closed this Jan 8, 2024

pbrezina added Pushed and removed Accepted labels Jan 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests: Add passkey test cases for following scenario #6965

Tests: Add passkey test cases for following scenario #6965

madhuriupadhye commented Sep 29, 2023

ikerexxe left a comment

spoore1 left a comment

madhuriupadhye commented Oct 6, 2023

ikerexxe commented Oct 19, 2023

spoore1 left a comment

spoore1 left a comment

spoore1 left a comment

spoore1 left a comment

ikerexxe left a comment

ikerexxe left a comment

justin-stephenson left a comment

spoore1 left a comment

jakub-vavra-cz commented Jan 5, 2024

pbrezina commented Jan 8, 2024

Tests: Add passkey test cases for following scenario #6965

Tests: Add passkey test cases for following scenario #6965

Conversation

madhuriupadhye commented Sep 29, 2023

ikerexxe left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

madhuriupadhye commented Oct 6, 2023

ikerexxe commented Oct 19, 2023

spoore1 left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

ikerexxe left a comment

Choose a reason for hiding this comment

ikerexxe left a comment

Choose a reason for hiding this comment

justin-stephenson left a comment

Choose a reason for hiding this comment

spoore1 left a comment

Choose a reason for hiding this comment

jakub-vavra-cz commented Jan 5, 2024

pbrezina commented Jan 8, 2024