Tests: alltests/test_offline.py converted to system/tests/test_offline.py #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed your remarks |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
patriki01
force-pushed
the
offline
branch
2 times, most recently
from
87356c5 to
31c56fd
Compare
|
Code LGTM, but I won't approve this PR until SSSD/sssd-test-framework#54 is merged and CI is green. |
|
We moved journalctl command to new repo, so I reflect this change. |
patriki01
force-pushed
the
offline
branch
3 times, most recently
from
0164927 to
549ae7b
Compare
ikerexxe
approved these changes
Dec 11, 2023
|
@danlavu can we proceed? |
danlavu
requested changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted two offline tests for LDAP.
I also edited the original test
test_0002_bz1928648because it was not revertingiptablescommand if the test failed.Blocked by : next-actions/pytest-mh#23