Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: alltests/test_sssctl_analyzer.py converted to tests/test_sssctl_analyze.py #7065

Closed
wants to merge 1 commit into from

Conversation

patriki01
Copy link
Contributor

Another tests converted to the new framework.
Feel free to suggest changes.

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss where to run this, it does not make a sense to me to run this against all backends.

src/tests/system/tests/test_sssctl_analyze.py Outdated Show resolved Hide resolved
@patriki01 patriki01 force-pushed the analyzer branch 5 times, most recently from 6fbbd2d to 7f1a13c Compare December 8, 2023 09:19
@patriki01
Copy link
Contributor Author

Converted tests are green, failures unrelated.

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Member

Pushed PR: #7065

  • master
    • 543eda1 - Tests: multihost/test_sssctl_analyzer.py converted to system/test_sssctl_analyze.py
  • sssd-2-9
    • 8a78c75 - Tests: multihost/test_sssctl_analyzer.py converted to system/test_sssctl_analyze.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants