[Pytest] Port AD id mapping tests to the new framework

.github/workflows/analyze-target.yml

@@ -1,7 +1,7 @@
 name: "Analyze (target)"
 on:
   pull_request_target:
-    branches: [master, sssd-2-7, sssd-2-8]
+    branches: [master, sssd-2-7, sssd-2-8, sssd-2-9]
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
   cancel-in-progress: true
@@ -13,14 +13,14 @@ jobs:
       pull-requests: write
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         ref: ${{ github.event.pull_request.head.sha }}
         persist-credentials: false
 
     - name: Perform cppcheck analysis
       # v0.0.11 is the latest release but we need a later commit
-      uses: linuxdeepin/action-cppcheck@9ef62c4ec8cd5660952cd02c58b83fa57c16a42b
+      uses: linuxdeepin/action-cppcheck@e63fb1d3f321e0467737aa9de7f691360fb1b8fb
       with:
         github_token: ${{ secrets.GITHUB_TOKEN }}
         repository: ${{ github.repository }}
@@ -36,13 +36,13 @@ jobs:
     timeout-minutes: 1440
     steps:
     - name: Checkout target branch
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         ref: ${{ github.base_ref }}
         path: target
 
     - name: Checkout pull request branch
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         ref: ${{ github.event.pull_request.head.sha }}
         path: pr
@@ -76,7 +76,7 @@ jobs:
 
     - name: Upload artifacts
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         if-no-files-found: ignore
         name: covscan

.github/workflows/ci.yml

@@ -1,9 +1,9 @@
 name: "ci"
 on:
   push:
-    branches: [master, sssd-2-7, sssd-2-8]
+    branches: [master, sssd-2-7, sssd-2-8, sssd-2-9]
   pull_request:
-    branches: [master, sssd-2-7, sssd-2-8]
+    branches: [master, sssd-2-7, sssd-2-8, sssd-2-9]
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
@@ -15,7 +15,7 @@ jobs:
       contents: read
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Install dependencies
       id: dependencies
@@ -45,7 +45,7 @@ jobs:
         source ../contrib/fedora/bashrc_sssd
         make distcheck
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       if: always()
       with:
         name: build
@@ -63,7 +63,7 @@ jobs:
       matrix: ${{ steps.matrix.outputs.matrix }}
     steps:
     - name: Checkout sources
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Get matrix
       id: matrix
@@ -80,7 +80,7 @@ jobs:
       contents: read
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         path: sssd
 
@@ -115,7 +115,7 @@ jobs:
 
     - name: Upload main artifacts
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         if-no-files-found: ignore
         name: ${{ matrix.tag }}-intgcheck
@@ -124,10 +124,11 @@ jobs:
           ./sssd/ci-build-debug/ci-*.log
           ./sssd/ci-build-debug/test-suite.log
           ./sssd/ci-build-debug/ci-mock-result/*.log
+          ./sssd/ci-build-debug/src/tests/cwrap/test-suite.log
 
     - name: Upload valgrind artifacts
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         if-no-files-found: ignore
         name: ${{ matrix.tag }}-intgcheck-valgrind
@@ -145,7 +146,7 @@ jobs:
       contents: read
     steps:
     - name: Checkout sssd repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         path: sssd
 
@@ -214,7 +215,7 @@ jobs:
         pip3 install -r ./sssd/src/tests/multihost/requirements.txt
 
     - name: Create multihost configuration
-      uses: DamianReeves/write-file-action@41569a7dac64c252caacca7bceefe28b70b38db1
+      uses: DamianReeves/write-file-action@0a7fcbe1960c53fc08fe789fa4850d24885f4d84
       with:
         path: mhc.yml
         write-mode: overwrite
@@ -237,7 +238,7 @@ jobs:
 
     - name: Upload artifacts
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         if-no-files-found: ignore
         name: ${{ matrix.tag }}-multihost
@@ -258,7 +259,7 @@ jobs:
       contents: read
     steps:
     - name: Checkout sssd repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         path: sssd
 
@@ -276,12 +277,22 @@ jobs:
               - /dev/shm
               volumes:
               - ../sssd:/sssd:rw
+            ipa:
+              image: ${REGISTRY}/ci-ipa-devel:${TAG}
+              shm_size: 4G
+              tmpfs:
+              - /dev/shm
+              volumes:
+              - ../sssd:/sssd:rw
 
-    - name: Build SSSD on the client
+    - name: Build SSSD on the client and IPA
       uses: SSSD/sssd-ci-containers/actions/exec@master
       with:
         log-file: build.log
         working-directory: /sssd
+        where: |
+          client
+          ipa
         script: |
           #!/bin/bash
           set -ex
@@ -294,22 +305,35 @@ jobs:
           /sssd/configure --enable-silent-rules
           make rpms
 
-    - name: Install SSSD on the client
+    - name: Install SSSD on the client and IPA
       uses: SSSD/sssd-ci-containers/actions/exec@master
       with:
         log-file: install.log
         user: root
+        where: |
+          client
+          ipa
         script: |
           #!/bin/bash
           set -ex
 
-          dnf remove -y --noautoremove sssd\*
           dnf install -y /dev/shm/sssd/rpmbuild/RPMS/*/*.rpm
           rm -fr /dev/shm/sssd
 
           # We need to reenable sssd-kcm since it was disabled by removing sssd not not enabled again
           systemctl enable --now sssd-kcm.socket
 
+    - name: Restart SSSD on IPA server
+      uses: SSSD/sssd-ci-containers/actions/exec@master
+      with:
+        user: root
+        where: ipa
+        script: |
+          #!/bin/bash
+          set -ex
+
+          systemctl restart sssd || systemctl status sssd
+
     - name: Install system tests dependencies
       shell: bash
       working-directory: ./sssd/src/tests/system
@@ -339,23 +363,45 @@ jobs:
       run: |
         yq -i 'del(.domains[0].hosts.[] | select(.role == "ad"))' mhc.yaml
 
+    - name: Check polarion metadata
+      shell: bash
+      working-directory: ./sssd/src/tests/system
+      run: |
+        # Run pytest in collect only mode to quickly catch issues in Polarion metadata.
+        set -ex -o pipefail
+
+        mkdir -p $GITHUB_WORKSPACE/artifacts
+        source .venv/bin/activate
+        pytest \
+          --color=yes \
+          --mh-config=./mhc.yaml \
+          --mh-log-path=$GITHUB_WORKSPACE/mh.log \
+          --mh-artifacts-dir=$GITHUB_WORKSPACE/artifacts \
+          --polarion-config=./polarion.yaml \
+          --output-polarion-testcase=$GITHUB_WORKSPACE/artifacts/testcase.xml \
+          --collect-only . |& tee $GITHUB_WORKSPACE/pytest-collect.log
+
     - name: Run tests
       shell: bash
       working-directory: ./sssd/src/tests/system
       run: |
         set -ex -o pipefail
 
+        mkdir -p $GITHUB_WORKSPACE/artifacts
         source .venv/bin/activate
         pytest \
           --color=yes \
           --mh-config=./mhc.yaml \
           --mh-log-path=$GITHUB_WORKSPACE/mh.log \
           --mh-artifacts-dir=$GITHUB_WORKSPACE/artifacts \
+          --polarion-config=./polarion.yaml \
+          --output-polarion-testcase=$GITHUB_WORKSPACE/artifacts/testcase.xml \
+          --output-polarion-testrun=$GITHUB_WORKSPACE/artifacts/testrun.xml \
           -vvv . |& tee $GITHUB_WORKSPACE/pytest.log
 
     - name: Upload artifacts
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         if-no-files-found: ignore
         name: ${{ matrix.tag }}-system
@@ -366,6 +412,7 @@ jobs:
           build.log
           install.log
           pytest.log
+          pytest-collect.log
 
   result:
     name: All tests are successful

.github/workflows/copr_build.yml

@@ -21,7 +21,7 @@
 name: copr
 on:
   pull_request_target:
-    branches: [master, sssd-2-7, sssd-2-8]
+    branches: [master, sssd-2-7, sssd-2-8, sssd-2-9]
     types: [opened, synchronize, reopened]
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
@@ -41,7 +41,7 @@ jobs:
       contents: read
     steps:
     - name: Checkout source
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         ref: ${{ github.event.pull_request.head.ref }}
         repository: ${{ github.event.pull_request.head.repo.full_name }}
@@ -53,7 +53,7 @@ jobs:
         version: 9.${{ env.COPR_PROJECT }}
 
     - name: Upload source rpm as an artifact
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ steps.srpm.outputs.file }}
         path: ${{ steps.srpm.outputs.path }}
@@ -96,7 +96,7 @@ jobs:
       run: |
         # CentOS Stream 8
         copr-cli --config "$coprcfg" edit-chroot                                                        \
-          --repos 'https://koji.mbox.centos.org/kojifiles/repos/dist-c8-stream-build/latest/$basearch/' \
+          --repos 'https://kojihub.stream.centos.org/kojifiles/repos/c8s-build/latest/$basearch'        \
           --modules idm:DL1                                                                             \
           $COPR_ACCOUNT/$COPR_PROJECT/centos-stream-8-x86_64
 
@@ -114,10 +114,10 @@ jobs:
       fail-fast: false
     steps:
     - name: Checkout source
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Downlooad source rpm
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ${{ needs.prepare.outputs.srpm }}
         path: .

.github/workflows/copr_cleanup.yml

@@ -1,7 +1,7 @@
 name: copr cleanup
 on:
   pull_request_target:
-    branches: [master, sssd-2-7, sssd-2-8]
+    branches: [master, sssd-2-7, sssd-2-8, sssd-2-9]
     types: [closed]
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number }}

.github/workflows/coverity.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Install dependencies
       uses: ./.github/actions/install-dependencies
@@ -22,7 +22,7 @@ jobs:
       uses: ./.github/actions/configure
 
     - name: Execute and submit coverity scan
-      uses: vapier/coverity-scan-action@v1.2.0
+      uses: vapier/coverity-scan-action@v1.7.0
       with:
         email: "[email protected]"
         token: ${{ secrets.COVERITY_SCAN_TOKEN }}