Test: Port AD id mapping tests to the new framework #7172
Conversation
|
Hi, please add a meaningful commit message. |
|
Hi @liswang89 Thanks for the contribution :) we really appreciate it. You can find more details on the standards at https://sssd.io/contrib/introduction.html -> there is a template we expect, which can be found at https://github.com/SSSD/sssd/blob/master/.git-commit-template If you want to check other PRs to have some real examples, here are some of them: #6409 #7161 #7160 Since there is no "Git Hub" issue created for that, I don't know if we can link to our internal SSSD Jira. I'll defer it to @alexey-tikhonov or @pbrezina to tell. Should we create a GH Issue? Or just leave it blank? Can we use Resolves: SSSD Jira? Please advise. |
No, we shouldn't link to URLs that aren't publicly accessible.
Just don't add "Resolve" line in this case. In this case I merely asked about description what was done (what "new tests": type of test? what does those tests do?) in a plain words. |
liswang89
changed the title
|
All of the user/group creation should be part of setup. |
|
Please add the converted marker like this one to the original test: |
There was a problem hiding this comment.
Looks great inmplementation-wise. Thank You.
Please fix the code style, otherwise LGTM:
./tests/test_identity.py:525:61: W291 trailing whitespace
./tests/test_identity.py:542:1: W293 blank line contains whitespace
./tests/test_identity.py:547:119: W292 no newline at end of file
|
Just Jakub's changes and a rebase. |
|
|
||
| assert client.tools.getent.group("nonposix_group") is None, 'non-posix group is returned by sssd, it should not be' | ||
| assert client.tools.getent.passwd("nonposix_user") is None, 'non-posix user is returned by sssd, it should not be' | ||
|
|
There was a problem hiding this comment.
There is some extra whitespace reported by the pep8 at L548.
There was a problem hiding this comment.
@jakub-vavra-cz Thanks for pointing that out. The PR has been updated.
Introduced by SSSD#7172.
Introduced by #7172. Reviewed-by: Alexey Tikhonov <[email protected]>
Introduced by #7172. Reviewed-by: Alexey Tikhonov <[email protected]> (cherry picked from commit e9253e0)
Port the following tests [https://github.com/SSSD/sssd/blob/master/src/tests/multihost/ad/test_idmap.py] to the new framework.