Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sssd: adding mail as case insensitive #7174

Closed

Conversation

andreboscatto
Copy link
Contributor

Resolves: #7173

@andreboscatto andreboscatto marked this pull request as draft February 7, 2024 11:30
@andreboscatto andreboscatto force-pushed the sssd-fix-mail-case-insensitve branch from 8a14894 to 7c283d8 Compare February 7, 2024 11:36
@andreboscatto andreboscatto force-pushed the sssd-fix-mail-case-insensitve branch from 7c283d8 to 0b1369b Compare February 7, 2024 11:43
@andreboscatto
Copy link
Contributor Author

andreboscatto commented Feb 7, 2024

Before updating SSSD

allopez@alf:~/ws/repos/sssd-ci-containers$ ssh [email protected]@client.test
([email protected]@client.test) Password: 
Creating home directory for [email protected].
-sh-5.2$ ^C
-sh-5.2$ 
logout
Connection to client.test closed.

and it fails searching with all lower case mail attribute:

llopez@alf:~/ws/repos/sssd-ci-containers$ ssh [email protected]@client.test
([email protected]@client.test) Password: 
([email protected]@client.test) Password: 
([email protected]@client.test) Password: 

After updating SSSD

searching with all lower case mail attribute:

allopez@alf:~/ws/repos/sssd-ci-containers$ ssh [email protected]@client.test
([email protected]@client.test) Password: 
Last failed login: Wed Feb  7 12:59:24 UTC 2024 from 172.16.100.1 on ssh:notty
There were 4 failed login attempts since the last successful login.
Last login: Wed Feb  7 12:58:54 2024 from 172.16.100.1
-sh-5.2$ 
logout
Connection to client.test closed.

searching with the exact mail attribute as registered:

allopez@alf:~/ws/repos/sssd-ci-containers$ ssh [email protected]@client.test
([email protected]@client.test) Password: 
Last login: Wed Feb  7 13:01:41 2024 from 172.16.100.1
-sh-5.2$ 
logout
Connection to client.test closed.

searching with all caps letter mail attribute:

allopez@alf:~/ws/repos/sssd-ci-containers$ ssh [email protected]@client.test
([email protected]@client.test) Password: 
Last login: Wed Feb  7 13:01:56 2024 from 172.16.100.1
-sh-5.2$ 
logout
Connection to client.test closed.

Thank you so much for helping me with testing @aplopez :)

@andreboscatto andreboscatto marked this pull request as ready for review February 7, 2024 14:36
@andreboscatto andreboscatto added branch: sssd-1-16 Target also sssd-1-16 branch backport-to-stable labels Feb 7, 2024
@alexey-tikhonov alexey-tikhonov removed the branch: sssd-1-16 Target also sssd-1-16 branch label Feb 8, 2024
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Feb 8, 2024

@andreboscatto, I removed branch: sssd-1-16 because patch won't apply there.
It has different sysdb versions - see

#define SYSDB_VERSION_0_22 "0.22"

If you want to fix 1-16 as well you need to backport manually and open explicit PR.

@thalman
Copy link
Contributor

thalman commented Feb 9, 2024

CI failure is not connected with the patch.

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreboscatto, ACK

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job Andre!

@alexey-tikhonov
Copy link
Member

Pushed PR: #7174

  • master
    • 945cebc - sssd: adding mail as case insensitive
  • sssd-2-9
    • dd0f632 - sssd: adding mail as case insensitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants