Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Drop files provider from tests test_sssctl_ldap.py #7182

Closed
wants to merge 1 commit into from
Closed

Tests: Drop files provider from tests test_sssctl_ldap.py #7182

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

Review if any of "multihost tests" depend on "files provider". Remove found dependencies.

@alexey-tikhonov
Copy link
Member

Please get rid of this copy&paste:

        sssd_param = {'domains': 'local'}
        tools.sssd_conf('sssd', sssd_param)
        param = {'id_provider': 'proxy',
                 'proxy_lib_name': 'files',
                 'proxy_pam_target': 'sssd-shadowutils'}
        tools.sssd_conf('domain/local', param)
        tools.sssd_conf("sssd", {'services': 'nss, pam, ifp'}, action='update')

@aborah-sudo aborah-sudo force-pushed the test_sssctl_ldap branch 2 times, most recently from 7f225ca to eace829 Compare February 23, 2024 01:54
@aborah-sudo aborah-sudo force-pushed the test_sssctl_ldap branch 2 times, most recently from 7b7d821 to ee67052 Compare March 3, 2024 13:16
@aborah-sudo
Tests: Drop files provider from tests test_sssctl_ldap.py
210266b 
Review if any of "multihost tests" depend on "files provider".
Remove found dependencies.
madhuriupadhye
madhuriupadhye approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@madhuriupadhye madhuriupadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #7182

  • master
    • 83f1ba7 - Tests: Drop files provider from tests test_sssctl_ldap.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov left review comments

@shridhargadekar shridhargadekar shridhargadekar approved these changes

@madhuriupadhye madhuriupadhye madhuriupadhye approved these changes

Assignees

@shridhargadekar shridhargadekar

@madhuriupadhye madhuriupadhye

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aborah-sudo @alexey-tikhonov @jakub-vavra-cz @shridhargadekar @madhuriupadhye