Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH: Make sss_ssh_knownhostsproxy build conditional #7223

Closed
wants to merge 2 commits into from

Conversation

aplopez
Copy link
Contributor

@aplopez aplopez commented Feb 28, 2024

Because the sss_ssh_knownhostsproxy tool will be removed in the future, we start by building, by default, an alternative version that just displays a warning.

To build the full, old working tool use:

./configure --with-ssh-known-hosts-proxy

The spec file was modified to use the --with-ssh-known-hosts-proxy option up to Fedora 41 and up to RHEL9. On Fedora 42 and RHEL10 the option will not be used and the alternative sss_ssh_knownhostsproxy tool, which just displays a messages, will be delivered. These versions can still be modified.

@aplopez aplopez marked this pull request as draft February 29, 2024 08:26
@aplopez aplopez marked this pull request as ready for review February 29, 2024 10:24
@aplopez aplopez marked this pull request as draft February 29, 2024 10:25
@aplopez aplopez force-pushed the known-hosts branch 2 times, most recently from b12a8e9 to 686aa49 Compare February 29, 2024 10:38
@alexey-tikhonov alexey-tikhonov self-assigned this Feb 29, 2024
@aplopez aplopez force-pushed the known-hosts branch 5 times, most recently from 1030de9 to 5ae17ed Compare March 1, 2024 16:26
@alexey-tikhonov
Copy link
Member

@aplopez, is this still a draft?

@aplopez
Copy link
Contributor Author

aplopez commented Mar 4, 2024

@aplopez, is this still a draft?

Of course not. Thanks.

@aplopez aplopez marked this pull request as ready for review March 4, 2024 15:22
@aplopez aplopez added the no-backport This should go to target branch only. label Mar 5, 2024
@aplopez aplopez requested a review from sumit-bose March 12, 2024 13:37
aplopez added 2 commits March 13, 2024 13:22
Because this tool will be removed, we start by building an alternative
version that just displays a warning.

To build the full working tool:
```
./configure --with-ssh-known-hosts-proxy
```
Until ipa-client-install is fixed to recognize the new tool
/usr/bin/sss_ssh_knownhosts, ssh's configuration must be manually
fixed.

Once the fixed FreeIPA is included in the container, this workaround
can be removed.
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the patch, ACK.

bye,
Sumit

@pbrezina
Copy link
Member

Pushed PR: #7223

  • master
    • e556bfd - TESTS: Fix the ssh configuration
    • c67e41d - SSH: Make sss_ssh_knownhostsproxy build conditional

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Mar 15, 2024
@pbrezina pbrezina closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants