-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
man: fix default value for pam_passkey_auth #7227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thanks, now the man page matches the code at https://github.com/SSSD/sssd/blob/master/src/responder/pam/pamsrv.c#L52, ACK.
bye,
Sumit
Why is 'pam_passkey_auth = true' but 'pam_cert_auth = false' by default? I'm also not sure about 'Fixes: commit-hash' notation - script that prepares release notes most probably won't like it. |
The default was changed to true in c76ba34 ("PAM: Passkey kerberos preauth support"), but the man page wasn't updated. Signed-off-by: Iker Pedrosa <[email protected]>
No idea 😅
I changed it, thanks for the feedback. |
Why do we want 'passkey_auth' enabled by default? Doesn't this trigger additional steps in krb pre-auth for users who doesn't use passkey? |
No, you'd still need to enable passkey authentication per user ( |
It's enough to have it enabled locally to have additional pre-auth step: https://issues.redhat.com/browse/RHEL-21786?focusedId=24266630&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24266630 Besides this being visible in the logs (and thus rendering questions) this probably (? I don't know) adds some latency. |
Hi, Smartcard authentication isn't enabled by default because checking the presence of a Smartcard might cause delays in the order of a few seconds for every authentication attempt. HTH bye, |
The default was changed to true, but the man page wasn't updated.
Fixes: c76ba34