tests: add 'expo_force' tests #7726
Conversation
shridhargadekar
force-pushed
the
exop_grace
branch
from
390249c to
a7ea772
Compare
The new value for the ldap_pwmodify_mode option 'exop_force' is added to existing test. A new test to illustrate the different behavior of 'exop' and 'exop_force' is added. Reviewed-by: Justin Stephenson <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit deefe9a)
shridhargadekar
force-pushed
the
exop_grace
branch
from
a7ea772 to
27d32db
Compare
| @@ -14,8 +16,7 @@ | |||
|
|
|||
| @pytest.mark.ticket(bz=[795044, 1695574]) | |||
| @pytest.mark.importance("critical") | |||
| @pytest.mark.authentication | |||
There was a problem hiding this comment.
Is this removal intentional / why?
There was a problem hiding this comment.
The authentication marker has been dropped. The 'critical' marker is being used from branch 2-9 onwards.
| @@ -56,7 +57,8 @@ def test_ldap__change_password(client: Client, ldap: LDAP, modify_mode: str): | |||
|
|
|||
|
|
|||
| @pytest.mark.ticket(bz=[795044, 1695574]) | |||
| @pytest.mark.parametrize("modify_mode", ["exop", "ldap_modify"]) | |||
| @pytest.mark.importance("critical") | |||
There was a problem hiding this comment.
If all of this intentional - addition of "critical", removal of "authentication", etc, then I would prefer to have those in a separate preliminary commit.
And then a clean backport cherry-pick on top.
CC @danlavu
There was a problem hiding this comment.
These are those unwarranted changes I was talking about in MR ldap_login_grace. sssd-2-9 and master have 'critical' as importance markers. Whereas sssd-2-9-4 (rhel-8-10) has 'authentication' marker.
These kind of changes are not even related to the main MR.
There was a problem hiding this comment.
These are those unwarranted changes I was talking about in MR ldap_login_grace. sssd-2-9 and master have 'critical' as importance markers. Whereas sssd-2-9-4 (rhel-8-10) has 'authentication' marker.
These kind of changes are not even related to the main MR.
There was a problem hiding this comment.
That' why instead of cherry picking the MR, I chose to backport manually in #7722
There was a problem hiding this comment.
Hello,
please add a detection of exop_force feature and run these tests with it only when it is available.
As exop_force is a new functionality it should have its own feature jira and requirement synced to the polarion. The requirement and ticket should be present here.
|
Hello, |
The new value for the ldap_pwmodify_mode option 'exop_force' is added to existing test. A new test to illustrate the different behavior of 'exop' and 'exop_force' is added.
Reviewed-by: Justin Stephenson [email protected]
Reviewed-by: Pavel Březina [email protected]
(cherry picked from commit deefe9a)