Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: have analyzer request child parse child log #7750

Closed
wants to merge 1 commit into from
Closed

tests: have analyzer request child parse child log #7750

wants to merge 1 commit into from

Conversation

justin-stephenson
Copy link
Contributor

@justin-stephenson justin-stephenson commented Dec 5, 2024 •
edited
Loading

This test was intended to test the --child argument, but was not actually parsing any child log files.

@justin-stephenson justin-stephenson force-pushed the analyzer_fix_child branch 2 times, most recently from a7c7d51 to 6c3849f Compare December 5, 2024 20:22
@justin-stephenson justin-stephenson marked this pull request as ready for review December 9, 2024 13:32
thalman
thalman approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ACK

danlavu
danlavu requested changes Dec 10, 2024
View reviewed changes
src/tests/system/tests/test_sssctl.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sssctl.py Show resolved Hide resolved
src/tests/system/tests/test_sssctl.py Outdated Show resolved Hide resolved
danlavu
danlavu approved these changes Dec 17, 2024
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M, thanks Justin.

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Jan 6, 2025
@alexey-tikhonov
Copy link
Member

Pushed PR: #7750

  • master
    • 4fbf963 - tests: have analyzer request child parse child log
  • sssd-2-10
    • f7258c4 - tests: have analyzer request child parse child log
  • sssd-2-9
    • d0d8b0a - tests: have analyzer request child parse child log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalman thalman thalman approved these changes

@danlavu danlavu danlavu approved these changes

Assignees

@thalman thalman

@danlavu danlavu

Labels
branch: sssd-2-9 branch: sssd-2-10 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justin-stephenson @alexey-tikhonov @thalman @danlavu @ikerexxe