Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore '--dumpable' argument in 'krb5_child' and 'ldap_child' #7755

Closed
wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

to avoid leaking host keytab accidentially.

Take a note that this is rather a general precaution than a fix of a real threat since normally those coredumps wouldn't be accessible to non-privileged user anyway.

Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I'm fine with the patch, ACK.

Instead of just "Ignored" maybe "Ignored, settings from /proc/sys/fs/suid_dumpable are used" can be used?

bye,
Sumit

to avoid leaking host keytab accidentially.

Take a note that this is rather a general precaution than a fix
of a real threat since normally those coredumps wouldn't be
accessible to non-privileged user anyway.
@alexey-tikhonov
Copy link
Member Author

Instead of just "Ignored" maybe "Ignored, settings from /proc/sys/fs/suid_dumpable are used" can be used?

Updated.

@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7755

  • master
    • 548fdb3 - Ignore '--dumpable' argument in 'krb5_child' and 'ldap_child' to avoid leaking host keytab accidentially.
  • sssd-2-10
    • 3c0c33d - Ignore '--dumpable' argument in 'krb5_child' and 'ldap_child' to avoid leaking host keytab accidentially.

alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this pull request Jan 9, 2025
to avoid leaking host keytab accidentially.

Take a note that this is rather a general precaution than a fix of a real threat
since normally those coredumps wouldn't be accessible to non-privileged user anyway.

This is an addition to SSSD#7755
alexey-tikhonov added a commit that referenced this pull request Jan 16, 2025
to avoid leaking host keytab accidentially.

Take a note that this is rather a general precaution than a fix of a real threat
since normally those coredumps wouldn't be accessible to non-privileged user anyway.

This is an addition to #7755

Reviewed-by: Iker Pedrosa <[email protected]>
Reviewed-by: Pavel Březina <[email protected]>
alexey-tikhonov added a commit that referenced this pull request Jan 16, 2025
to avoid leaking host keytab accidentially.

Take a note that this is rather a general precaution than a fix of a real threat
since normally those coredumps wouldn't be accessible to non-privileged user anyway.

This is an addition to #7755

Reviewed-by: Iker Pedrosa <[email protected]>
Reviewed-by: Pavel Březina <[email protected]>
(cherry picked from commit 85784e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants