Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Test trasformation for netgroup with generic provider #7760

Closed
wants to merge 1 commit into from
Closed

Tests: Test trasformation for netgroup with generic provider #7760

wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

Test trasformation for netgroup with generic provider

@aborah-sudo aborah-sudo force-pushed the new_net branch 4 times, most recently from 769ce52 to 4dbb023 Compare December 16, 2024 09:22
@aborah-sudo aborah-sudo force-pushed the new_net branch 2 times, most recently from fb6b102 to 24fdb33 Compare January 6, 2025 04:33
ikerexxe
ikerexxe requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the first test case. Once I'm fine with it I'll proceed with the rest.

src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
@aborah-sudo aborah-sudo requested a review from ikerexxe January 8, 2025 04:25
@aborah-sudo aborah-sudo force-pushed the new_net branch 6 times, most recently from 9ef6750 to c949b58 Compare January 17, 2025 06:06
@aborah-sudo aborah-sudo requested review from jakub-vavra-cz and removed request for danlavu January 20, 2025 05:40
@aborah-sudo aborah-sudo force-pushed the new_net branch 2 times, most recently from 4fa8f7a to e2be2cc Compare January 23, 2025 04:14
ikerexxe
ikerexxe reviewed Jan 23, 2025
View reviewed changes
src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_netgroups.py Outdated Show resolved Hide resolved
@aborah-sudo aborah-sudo requested a review from ikerexxe January 23, 2025 09:00
@aborah-sudo aborah-sudo force-pushed the new_net branch 3 times, most recently from 35ea3e1 to 34f1b91 Compare January 27, 2025 03:49
@aborah-sudo
Tests: Test trasformation for netgroup with generic provider
f2b1945 
Test trasformation for netgroup with generic provider
ikerexxe
ikerexxe approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aborah-sudo aborah-sudo added the Ready to push Ready to push label Jan 27, 2025
@alexey-tikhonov
Copy link
Member

Pushed PR: #7760

  • master
    • a3ed676 - Tests: Test trasformation for netgroup with generic provider
  • sssd-2-10
    • ae2e2e9 - Tests: Test trasformation for netgroup with generic provider

@aborah-sudo aborah-sudo deleted the new_net branch February 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

Assignees

@ikerexxe ikerexxe

@jakub-vavra-cz jakub-vavra-cz

Labels
branch: sssd-2-10 Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aborah-sudo @alexey-tikhonov @ikerexxe @jakub-vavra-cz @danlavu